[PATCH] D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1)

Marc Auberer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 11:36:35 PDT 2022


marcauberer marked an inline comment as done.
marcauberer added a comment.

@RKSimon thanks for the review. I've uploaded improvements. Just one question left ...



================
Comment at: llvm/test/Transforms/InstCombine/add_or_sub.ll:26
+  ret i8 %add
+}
----------------
RKSimon wrote:
> vector cases? multiuse cases? negative cases?
I just added vector and multi-use cases. How do I do negative cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133362/new/

https://reviews.llvm.org/D133362



More information about the llvm-commits mailing list