[PATCH] D133275: [SimpleLoopUnswitch] Skip non-trivial unswitching of cold functions

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.

I don't think we need to worry about SPEC too much, just resolve regressions



================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/PGO-nontrivial-unswitch2.ll:89
 !14 = !{i32 999999, i64 1, i32 2}
 !15 = !{!"branch_weights", i32 100, i32 0}
 !16 = !{!"branch_weights", i32 0, i32 100}
----------------
looks like some of these aren't used? I think running this through `opt` without any passes should remove unused unnamed metadata


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133275/new/

https://reviews.llvm.org/D133275