[PATCH] D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

This looks fine, one comment to consider.



================
Comment at: llvm/lib/AsmParser/LLParser.cpp:2135
                                        bool &AteExtraComma) {
-  AteExtraComma = false;
-  while (EatIfPresent(lltok::comma)) {
+  while (AteExtraComma || EatIfPresent(lltok::comma)) {
+    AteExtraComma = false;
----------------
Are we sure AteExtraComma is initialized here? Often people pass an unitialized value into a reference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104269/new/

https://reviews.llvm.org/D104269