[PATCH] D131073: [AArch64][GlobalISel] Recognise some CCMPri

Tue Sep 6 10:14:12 PDT 2022

paquette added a comment.

Considering there was a miscompile with this last time, I think there's probably a missing testcase. Could you add a test which covers the part that was broken last time?

================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:4850
+      MIB.buildInstr(CCmpOpc, {}, {LHS});
+  if (C)
+    CCmp.addImm(C->Value.getZExtValue());
----------------
dmgreen wrote:
> tschuett wrote:
> > This condition is different from the one above? The  `C->Value.ult(32)` differs.
> Yeah, that was pretty daft. It was intended to clear the C if it wasn't set to anything useful. I've changed it to a opcode check instead.
It'd be nice to have a comment here

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131073/new/

https://reviews.llvm.org/D131073