[PATCH] D133239: [RISCV][MC] Add minimal support for Ztso extension

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 09:28:53 PDT 2022


reames added a comment.

In D133239#3769781 <https://reviews.llvm.org/D133239#3769781>, @asb wrote:

> There are a few other places we typically add some test coverage for a new extension (which might be overkill - something to reconsider in the future perhaps)
>
> - clang/test/Preprocessor/riscv-target-features.c
> - llvm/test/CodeGen/RISCV/attributes.ll
> - llvm/test/MC/attribute-arch.s
>
> Otherwise, changes look good to me.

I could not find llvm/test/MC/attribute-arch.s.  Did you have a different file in mind?  Added the other ones you mentioned.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133239/new/

https://reviews.llvm.org/D133239



More information about the llvm-commits mailing list