[PATCH] D133153: [support] Prepare TimeProfiler for cross-thread support

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop added a comment.

> Thanks again @russell.gallop, PTAL.

I noticed a warning:

  F:\git\llvm-project\llvm\lib\Support\TimeProfiler.cpp(75,3): warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
    TimeTraceProfilerEntry() = default;
    ^
  F:\git\llvm-project\llvm\lib\Support\TimeProfiler.cpp(69,23): note: default constructor of 'TimeTraceProfilerEntry' is implicitly deleted because field 'Start' of const-qualified type 'const (anonymous namespace)::TimePointType' (aka 'const time_point<std::chrono::steady_clock>') would not be initialized
    const TimePointType Start;
                        ^
  1 warning generated.

Please could you fix that?

> BTW am I using arc right? arc diff HEAD~3 --update D133153 <https://reviews.llvm.org/D133153> seems wrong.

I don't really know as I haven't used arc. I can't see the fix for a few of my comments (e.g. header line of unit test file) so maybe it didn't pick everything up.

I did some experiments compiling a test file. Without this patch there's a difference of < 1% with and without -ftime-trace. With this patch I see around 2% performance impact from adding -ftime-trace. I'm measuring the whole time with hyperfine on Windows. Maybe this is just in the noise. Do you see a similar effect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133153/new/

https://reviews.llvm.org/D133153