[PATCH] D133335: [RISCV] Improve vector fround lowering by changing FRM.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM to me too.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1894
     llvm_unreachable("Unexpected opcode");
   case ISD::FCEIL:
     Truncated =
----------------
Very minor style comment: the first three of these could be combined by tweaking the existing matchRoundingOp to directly map opcode to rounding mode and then reusing it here.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133335/new/

https://reviews.llvm.org/D133335