[PATCH] D133330: [InstCombine] Baseline tests for reducing icmp x, ~x and icmp ~x, x
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 6 04:48:31 PDT 2022
spatel added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/icmp-not.ll:20
+
+define i1 @icmp_not_sgt_2(i8 %x) {
+; CHECK-LABEL: @icmp_not_sgt_2(
----------------
As suggested in the other review, it would be better to give each test a descriptive name. I'd remove the "_1" suffixes and replace "_2" with "_swapped" or "_commuted".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133330/new/
https://reviews.llvm.org/D133330
More information about the llvm-commits
mailing list