[PATCH] D133334: [AMDGPU][MC] Warn when disassembling v_cmpx instructions

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:720
+      !OpIsExec(MI.getOperand(1)) && !OpIsZero(MI.getOperand(3))) {
+    outs() << "Warning: unexpected dst value\n";
+  }
----------------
foad wrote:
> Warnings should go to errs() shouldn't they?
What if to instead say what //is// expected?

Also, I guess it may be helpful if we emit the instruction itself and maybe its address as well? Might save the user some time and nerves locating the problematic instruction, especially if the warning doesn't go to that same stream we direct disassembled code to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133334/new/

https://reviews.llvm.org/D133334