[PATCH] D131290: [llvm-objdump] Create name for fake sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D131290#3771470 <https://reviews.llvm.org/D131290#3771470>, @MaskRay wrote:

> In D131290#3771459 <https://reviews.llvm.org/D131290#3771459>, @jhenderson wrote:
>
>> In D131290#3771385 <https://reviews.llvm.org/D131290#3771385>, @namhyung wrote:
>>
>>>   SmallVector<std::string, 0> SecNames; 
>>>   ...
>>>   SecNames.push_back(("PT_LOAD#" + Twine(Idx)).str());
>>>
>>> This makes the test failing again.
>>
>> Please see the second half of my previous comment re. vector resizing (can apply to SmallVector too potentially). I would expect that to be a problem.
>
> I think we should switch to what I originally suggested, drop StringTableBuilder and use a string with `\0` terminators:)

I'm actually inclined to agree - the "simplification" is turning out to be more complicated than I expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131290/new/

https://reviews.llvm.org/D131290