[PATCH] D133166: [mlir][MemRef] Canonicalize extract_strided_metadata(subview)

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added a comment.

Actually I forgot about some of the context in my last review, I am sorry .. the patterns we are talking about here should probably not be canonicalization patterns but rather patterns that we can apply with a specific new pass to fold away the subview ops in the presence of `memref.extract_strided_metadata`.
See https://reviews.llvm.org/D128986 for a PR that does these foldings with load/store operations.

I am unclear yet whether we want to add those patterns to the same pass or create a new pass but it seems possible to reuse and refactor pieces.
Helpers like `getLinearAffineExpr` can likely be reused and refactored to make more idiomatic use of OpFoldResult; emitting AffineApplyOp will be easier and not subject to cyclic dependences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133166/new/

https://reviews.llvm.org/D133166