[PATCH] D131290: [llvm-objdump] Create name for fake sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D131290#3771385 <https://reviews.llvm.org/D131290#3771385>, @namhyung wrote:

>   SmallVector<std::string, 0> SecNames; 
>   ...
>   SecNames.push_back(("PT_LOAD#" + Twine(Idx)).str());
>
> This makes the test failing again.

Please see the second half of my previous comment re. vector resizing (can apply to SmallVector too potentially). I would expect that to be a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131290/new/

https://reviews.llvm.org/D131290