[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 00:14:32 PDT 2022


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:8222
+          DT.reset();
+          getDT(*BB.getParent());
+          break;
----------------
LuoYuanke wrote:
> It seems not necessary to getDT immedately after `DT.reset`. The lazy `getDT` should help on compiling time.
If optimizeInst direct use the DT will fail. I meet some tests fail here before. So I add the getDT here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352



More information about the llvm-commits mailing list