[PATCH] D133325: [Driver] Allow search of included response files as configuration files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Normally a file included into configuration file by directive @file is
> searched for relative the including configuration file. In some cases it
> is not convenient.

Sorry, I am puzzled by the description. A configuration file may specify `--option=file` and `@cfg`.
Can you clarify which "file" you mean?

> Configuration parameters may be logically partitioned
> into caterories (like 'platform variant' and 'processor variant') and it
> is convenient to have different configuration files for these
> categories maintained separately. Similar motivation was described in
> https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606.
> Simple file inclusion by @file does not help, because in this case the
> path to file is specified relative to the directory of the used
> configuration file, but it actually is not dependent on the latter. Using
> absolute paths is not convenient and it still do not allow user to
> easily override the settings.

If the intention is to have `@cfg` in a configuration file to be resolved
relative to `--config-system-dir` or `--config-user-dir=`. Please describe the new semantics,
then mention the rationale. An example in `clang/docs/UsersManual.rst` will help.



================
Comment at: clang/include/clang/Driver/Options.td:909
+def search_config_dirs : Flag<["--"], "search-config-dirs">, Flags<[NoXarchOption]>,
+  HelpText<"Search for files included by configuration file is search directories">;
 def coverage : Flag<["-", "--"], "coverage">, Group<Link_Group>, Flags<[CoreOption]>;
----------------
I am confused by the help text.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133325/new/

https://reviews.llvm.org/D133325