[PATCH] D132839: [RISCV] Optimization for using compressed beqz and bnez PR#56391

[Liao Chunyu via Phabricator via llvm-commits]

liaolucy added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/compress-opt-branch.ll:5
+; choosen.
+;
+; RUN: cat %s | sed 's/CMPCOND/eq/g' | sed 's/RESBRNORMAL/bne/g' | \
----------------
ita-sc wrote:
> liaolucy wrote:
> > The testcase should be updated with this script, https://github.com/llvm/llvm-project/blob/main/llvm/utils/update_llc_test_checks.py. ignore if already used
> Hi
> Could you please add some information about it?
> I tried to do it, but looks like this script doesn't support pattern: 
> llc | llvm-objdump | FileCheck
> as expects llvm-objdump to be llc...
> 
> I tried to separate it, but pattern:
> llc | llvm-objdump > file
> cat file | FileCheck
> failed too with message: "Skipping non-FileChecked RUN line".
> But I need to update result with llvm-objdump to check for compressed instructions.
> 
llvm-project/llvm/test/CodeGen/RISCV/imm.ll as an example:
Command: /llvm-project/llvm/utils/update_llc_test_checks.py --llc-binary=/llvm-project/build/bin/llc llvm-project/llvm/test/CodeGen/RISCV/imm.ll 
If the relevant code is modified, the test case will be automatically updated.

But I see that the existing testcases of the c extension(compress-float.ll andcompress.ll) are not updated with the script, so I'm not sure if the testcase  of c extension really need to be updated with the script now.  

Sorry, please ignore this comment.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132839/new/

https://reviews.llvm.org/D132839