[PATCH] D133279: [DirectX backend] Remove Attribute not for DXIL on CallInst

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 10:11:09 PDT 2022


python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILPrepare.cpp:163
           }
+          if (auto *CI = dyn_cast<CallInst>(&I)) {
+            CI->removeFnAttrs(AttrMask);
----------------
nikic wrote:
> Don't know if DXIL has invokes, but using CallBase here might be better to handle those as well.
Fixed. Thanks for pointing it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133279/new/

https://reviews.llvm.org/D133279



More information about the llvm-commits mailing list