[PATCH] D133238: [RISCV] Improve vector fceil/ffloor lowering by changing FRM.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 07:23:25 PDT 2022


frasercrmck added a comment.

Looks good to me.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:1034
 
+class VPseudoUnaryMaskTAFRM<VReg RetClass, VReg OpClass, string Constraint = ""> :
+        Pseudo<(outs GetVRegNoV0<RetClass>.R:$rd),
----------------
Really minor but I find `TAFRM` quite hard to parse. I dunno if `TA_FRM` is preferable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133238/new/

https://reviews.llvm.org/D133238



More information about the llvm-commits mailing list