[PATCH] D133165: [lld][COFF] Add support for overriding weak symbols in LLVM bitcode input

Mon Sep 5 06:17:38 PDT 2022

mstorsjo added a comment.

In D133165#3770117 <https://reviews.llvm.org/D133165#3770117>, @hans wrote:

> I'm still curious how our non-ThinLTO builds worked. I assume there is some nuance to "COFF doesn't support weak symbols"?

COFF does have weak aliases, and at least within the mingw/GNU ecosystem, there's ways that `__attribute__((weak))` is mapped to weak aliases, which mostly works to emulate ELF style weak symbols. Not sure if this is usable when building in MSVC mode or not - that could be what you've been using.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133165/new/

https://reviews.llvm.org/D133165