[PATCH] D132490: [LoopVectorize] Emit runtime checks correctly for nested loops

Mon Sep 5 05:51:06 PDT 2022

kpdev42 added a comment.
Herald added a subscriber: pcwang-thead.

In D132490#3748233 <https://reviews.llvm.org/D132490#3748233>, @fhahn wrote:

> In D132490#3748231 <https://reviews.llvm.org/D132490#3748231>, @kpdev42 wrote:
>
>> In D132490#3746679 <https://reviews.llvm.org/D132490#3746679>, @fhahn wrote:
>>
>>> Thanks for the update. As I mentioned in the previous message, I think it would be good to just land the test in this patch and I'll submit the code change separately. The test looks good to me.
>>
>> Thank you fer the review. 
>> Lets keep buildbot green. Please land both fix and test case on your own
>
> Thanks, the idea would be to commit the test first with the checks so it passes without the fix. The fix then only shows the improvements on the test case, so the bots would stay green at all time.

I am afraid that this test does not pass without fix, so far would you like to (a) modify the test, so that it would pass (diff check instead of overlap check) or (b) XFAIL the test or (c) maybe something else?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132490/new/

https://reviews.llvm.org/D132490