[PATCH] D126661: [MachineVerifier] Fix crash on early clobbered subreg operands.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 05:24:55 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2266
+    // somewhere is performed in visitMachineFunctionAfter()
+    if (((SubRangeCheck || MO->getSubReg() == 0) && (VNI->def != DefIdx)) ||
+        !SlotIndex::isSameInstr(VNI->def, DefIdx) ||
----------------
dfukalov wrote:
> foad wrote:
> > Don't need the last set of parens on this line.
> Formally yes, but without the parens I got
> ```
> warning: '&&' within '||' [-Wlogical-op-parentheses]
> note: place parentheses around the '&&' expression to silence this warning
> ```
By "the last set" I meant the parens around `VNI->def != DefIdx`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126661/new/

https://reviews.llvm.org/D126661



More information about the llvm-commits mailing list