[PATCH] D133286: [NFC] Add `DebugVariable` constructor that takes `DbgVariableIntrinsic *`
J. Ryan Stinnett via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 5 04:30:11 PDT 2022
jryans accepted this revision.
jryans added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me overall. I would think it's okay to land straight away, but it's also fine to bundle with rest of assignment tracking.
Marked as accepted even with an open question, as I assume you'll do the right thing either way. 😄
================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:3727
public:
+ DebugVariable(DbgVariableIntrinsic *DII);
+
----------------
It seems like it could be `const` and still access everything you need here...?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133286/new/
https://reviews.llvm.org/D133286
More information about the llvm-commits
mailing list