[PATCH] D133199: [ARM] Constant pools need 4-byte alignment if we only have tADR

[John Brawn via Phabricator via llvm-commits]

john.brawn added a comment.

In D133199#3769823 <https://reviews.llvm.org/D133199#3769823>, @labrinea wrote:

>> the expansion of cttz to a table
>
> Can you explain what that means?

D128911 <https://reviews.llvm.org/D128911> made cttz be expanded to a table lookup, with the table being placed in a constant pool.

> How does the test demostrate the difference in alignment compared to the old codegen <https://godbolt.org/z/s98v9rcaj>? Is it the `.p2align 2` directive?

Yes, it's the `.p2align 2`. Without that if you try to generate an object (https://godbolt.org/z/hdGsPccn8) you get "error: misaligned pc-relative fixup value".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133199/new/

https://reviews.llvm.org/D133199