[PATCH] D132942: [PowerPC][GISel]add support for float point arithmetic operations

Mon Sep 5 02:08:01 PDT 2022

shchenz added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.cpp:57-58

   // Try the default logic for non-generic instructions that are either copies
   // or already have some operands assigned to banks.
+  if (!isPreISelGenericOpcode(Opc) || Opc == TargetOpcode::G_PHI) {
----------------
shchenz wrote:
> nemanjai wrote:
> > It is not clear from the description why the handling of copies is changing here. Also, it would seem that the comment is no longer valid.
> See comment https://reviews.llvm.org/D127530#3769630
> I will update the comments later.
The comments seems wrong before the change and right now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132942/new/

https://reviews.llvm.org/D132942