[PATCH] D133267: [Verifier] Reject dllexport with non-default visibility

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 00:45:34 PDT 2022


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Verifier/dllstorage.ll:6
+
+; CHECK: dllexport GlobalValue must have default visibility
+declare hidden dllexport i32 @dllexport_hidden()
----------------
I presume we can't easily get the symbol names into these error messages?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133267/new/

https://reviews.llvm.org/D133267



More information about the llvm-commits mailing list