[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 4 23:08:39 PDT 2022


Naville added a comment.

In D132441#3769497 <https://reviews.llvm.org/D132441#3769497>, @steakhal wrote:

> LGTM, but prior approval I'll get a second pair of eyes.
> I'm not using windows.

It's not strictly Windows, the output is obviously meaningless if the test program failed to execute, which we detect with Z3_RETURNCODE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441



More information about the llvm-commits mailing list