[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Just a drive through review from me. Thanks for working on this!



================
Comment at: llvm/docs/TestingGuide.rst:624-627
+  The number of the line where this substitution is used, with an
+  optional integer offset.  These expand only if they appear
+  immediately in ``RUN:``, ``DEFINE:``, and ``REDEFINE:`` directives.
+  Occurrences in substitutions defined elsewhere are never expanded.
----------------
Why delete "This can be used in tests with multiple RUN lines, which reference test file's line numbers"?


================
Comment at: llvm/docs/TestingGuide.rst:694-696
+    ; DEFINE: %{triple} =
+    ; DEFINE: %{cflags} =
+    ; DEFINE: %{fc-prefix} =
----------------
What happens if these remain undefined? I couldn't find this documented or tested.


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-define/errors/continuation/unterminated-define-bad-redefine.txt:14
+# CHECK: Unresolved: 1
\ No newline at end of file

----------------
FIXME


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-define/errors/continuation/unterminated-define-redefine.txt:14
+# CHECK: Unresolved: 1
\ No newline at end of file

----------------
FIXME


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-define/errors/continuation/unterminated-define-run.txt:10
+# CHECK: Unresolved: 1
\ No newline at end of file

----------------
FIXME


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-define/errors/continuation/unterminated-define.txt:9
+# CHECK: Unresolved: 1
\ No newline at end of file

----------------
FIXME


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg:40
+  config.recursiveExpansionLimit = int(recur)
\ No newline at end of file

----------------
FIXME


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132513/new/

https://reviews.llvm.org/D132513