[PATCH] D132989: [InstSimplify] Odd - X ==/!= X -> false/true

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:3299
+      match(LHS, m_Sub(m_APInt(C), m_Value()))) {
+    if ((*C & 1) == 1) {
+      if (Pred == CmpInst::ICMP_EQ)
----------------
Can we use knownbits here instead to support non-uniform constant vectors?

I'm never very clear on when we're allowed to use value tracking in instsimplify as its more expensive....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132989/new/

https://reviews.llvm.org/D132989