[PATCH] D133257: [GISel] Fix match tree emitter.

Kai Nacke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 3 10:33:58 PDT 2022


Kai added a comment.

In D133257#3768704 <https://reviews.llvm.org/D133257#3768704>, @tschuett wrote:

> Did you forget the test case?

Oops, yes. The crash is easily verified by running llvm-tblgen without -gicombiner-stop-after-build option.
For the syntax errors I currently do not have a good test. I tried to rewrite one of the combine rules in 
Combine.td, but this resulted in some regression. :-( One issue with this code here is that it is obviously
not really used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133257/new/

https://reviews.llvm.org/D133257



More information about the llvm-commits mailing list