[PATCH] D133257: [GISel] Fix match tree emitter.

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 3 09:39:03 PDT 2022


tschuett added a comment.

Did you forget the test case?



================
Comment at: llvm/utils/TableGen/GlobalISel/CodeExpansions.h:28
     bool Inserted = Expansions.try_emplace(Name, Expansion).second;
-    assert(Inserted && "Declared variable twice");
+    // Duplicates are not inserted. The expansion refers to different operands
+    // but to the same virtual register.
----------------
You don't need the `Inserted` variable anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133257/new/

https://reviews.llvm.org/D133257



More information about the llvm-commits mailing list