[PATCH] D132988: Changes to use a string pool for symbols

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

Hi Jared, thanks for working on this! Your patch looks really good. Two minor comments inline.



================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:418
   static Symbol &constructCommon(BumpPtrAllocator &Allocator, Block &Base,
-                                 StringRef Name, orc::ExecutorAddrDiff Size,
-                                 Scope S, bool IsLive) {
-    assert(!Name.empty() && "Common symbol name cannot be empty");
+                                 orc::SymbolStringPtr &&Name,
+                                 orc::ExecutorAddrDiff Size, Scope S,
----------------
Is there a special reason for these methods to take RValue references? Otherwise, these look like classical sink arguments that should be moved in and taken by value (just remove the `&&`).


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:973
   LinkGraph &operator=(LinkGraph &&) = delete;
+  ~LinkGraph();
 
----------------
Do we have a definition for the dtor here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132988/new/

https://reviews.llvm.org/D132988