[PATCH] D132717: [AArch64] Add an option to reserve physical registers from RA

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 15:34:03 PDT 2022


Carrot added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:304
+  std::unordered_set<std::string> ReservedRegNames(ReservedRegsForRA.begin(),
+                                                   ReservedRegsForRA.end());
+  for (unsigned i = 0; i < 31; ++i) {
----------------
efriedma wrote:
> Please use StringMap (see https://llvm.org/docs/ProgrammersManual.html#llvm-adt-stringmap-h )
It looks StringSet is more appropriate.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132717/new/

https://reviews.llvm.org/D132717



More information about the llvm-commits mailing list