[PATCH] D132717: [AArch64] Add an option to reserve physical registers from RA

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:66
+                llvm::cl::desc("Reserve physical registers, "
+                               "so they can't be used by register allocator."),
+                cl::CommaSeparated, cl::Hidden);
----------------
Maybe note in the description that this is intended for testing the register allocator.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:304
+  std::unordered_set<std::string> ReservedRegNames(ReservedRegsForRA.begin(),
+                                                   ReservedRegsForRA.end());
+  for (unsigned i = 0; i < 31; ++i) {
----------------
Please use StringMap (see https://llvm.org/docs/ProgrammersManual.html#llvm-adt-stringmap-h )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132717/new/

https://reviews.llvm.org/D132717