[PATCH] D133222: use LLVM_USE_STATIC_ZSTD

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 13:31:59 PDT 2022


phosek added inline comments.


================
Comment at: llvm/lib/Support/CMakeLists.txt:28
 
-set(zstd_target none)
+set(zstd_target zstd::libzstd_nonexistant)
 
----------------
I'd delete this line altogether. In CMake, you don't need to define variables before you use them and there's no suitable default value here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133222/new/

https://reviews.llvm.org/D133222



More information about the llvm-commits mailing list