[PATCH] D133222: use LLVM_ZSTD_PREFERENCE_LIST in favor of LLVM_PREFER_STATIC_ZSTD

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 13:12:11 PDT 2022


phosek added a comment.

I'd prefer `LLVM_USE_STATIC_ZSTD ` name I suggested in D132870 <https://reviews.llvm.org/D132870>. `<PROJECT>_USE_STATIC_<DEPENDENCY>` is a common convention we already use elsewhere in LLVM. I'd prefer following the existing conventions rather than inventing a new approach for the sake of maintainability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133222/new/

https://reviews.llvm.org/D133222



More information about the llvm-commits mailing list