[PATCH] D130885: [AtomicExpandPass] Always copy pcsections Metadata to expanded atomics

Fri Sep 2 10:24:08 PDT 2022

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/test/Transforms/AtomicExpand/AArch64/pcsections.ll:4309
+; CHECK-NEXT:    [[NEW:%.*]] = xor i128 [[TMP1]], -1, !pcsections !0
+; CHECK-NEXT:    [[TMP2:%.*]] = cmpxchg i128* [[A]], i128 [[LOADED]], i128 [[NEW]] seq_cst seq_cst, align 16, !pcsections !0
+; CHECK-NEXT:    [[SUCCESS:%.*]] = extractvalue { i128, i1 } [[TMP2]], 1, !pcsections !0
----------------
I don't know how stable the order
often in such generated test I had to replace -NEXT with -DAG

9eadad51bafb741203e21d917a43d45c99fabe55
and
c0ee9e1b98cac2cc4b3369dbcf52486e4d294060
When it was -NEXT it failed bunch of bots, but I can't reproduce locally even with LLVM_REVERSE_ITERATION or LLVM_ENABLE_EXPENSIVE_CHECKS (I just noticed, that  i didn't try gcc, which is used on those bots)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130885/new/

https://reviews.llvm.org/D130885