[PATCH] D132989: [InstSimplify] Odd - X ==/!= X -> false/true

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 07:59:43 PDT 2022


liaolucy added a comment.

> If we do not have a real-world example that shows the more expensive transform is needed, then we should not add it. In other words, the patch is mostly fine as implemented. But I do not understand why we have no-wrap requirements. The transform is correct without those:
> https://alive2.llvm.org/ce/z/h4ZFVD

Actually, I'm not sure if just using srem(2) is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132989/new/

https://reviews.llvm.org/D132989



More information about the llvm-commits mailing list