[PATCH] D117499: [CodeGen] Support extracting fixed-length vectors from illegal scalable vectors

[David Sherwood via Phabricator via llvm-commits]

david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3034
+  if (SubVT.getScalarType() == MVT::i1)
+    llvm_unreachable("Don't know how to extract fixed-width predicate "
+                     "subvector from a scalable predicate vector");
----------------
efriedma wrote:
> Please use report_fatal_error so we get a diagnostic even if assertions aren't enabled.
Yes, you're absolutely right. Don't know what I was thinking!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117499/new/

https://reviews.llvm.org/D117499