[PATCH] D133201: [LLD][COFF] Fix Bug, occouring if Symbol has no name

[Jan Ole Hüser via Phabricator via llvm-commits]

j0le added inline comments.


================
Comment at: lld/COFF/Writer.cpp:399
   }
-  Defined *d = make<DefinedSynthetic>("", c);
+  Defined *d = make<DefinedSynthetic>("range_extension_thunk", c);
   lastThunk = d;
----------------
some questions:
- Should we give the symbol a name to fix the bug, instead of changing `Symbol::computeName()`?
- Is it allowed, that multiple symbols have the same name?

some questions not really related to the bug, but answers would help me understand LLD better. 
- why don't we use SymbolTable::addSynthetic()?
- Do we need to have this symbol in the symbol table?
- Is it added later to the symbol table?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133201/new/

https://reviews.llvm.org/D133201