[PATCH] D130076: [llvm/CodeGen] Enable the ExpandLargeDivRem pass for X86, Arm and AArch64

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 02:06:03 PDT 2022


pengfei added a comment.

In D130076#3766415 <https://reviews.llvm.org/D130076#3766415>, @mgehre-amd wrote:

> In D130076#3751142 <https://reviews.llvm.org/D130076#3751142>, @pengfei wrote:
>
>> The tests are too prolix to check the correctness and it's fragile to use so many registers. I suggest we remove those tests and just do run-time time in llvm-test-suite.
>
> Yes, you are right. I will restrict the IR tests to maybe just check for the absence of a call instructions? And at least to check that llc doesn't assert like it used to do.

Yes, checking no call instructions sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130076/new/

https://reviews.llvm.org/D130076



More information about the llvm-commits mailing list