[PATCH] D130177: [Matrix] Simplify matmuls with scalars

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:894
       optimizeTransposes();
-      LLVM_DEBUG({
+      if (PrintAfterTransposeOpt) {
         dbgs() << "Dump after matrix transpose optimization:\n";
----------------
Should we still print this when `-debug` is passed without `PrintAfterTransposeOpt`?


================
Comment at: llvm/test/Transforms/LowerMatrixIntrinsics/transpose-opts.ll:1162
+; AFTER-TRANSPOSE-NOT: llvm.matrix.transpose
+; AFTER-TRANSPOSE: llvm.matrix.multiply
+; AFTER-TRANSPOSE: store
----------------
This should probably check the operands are as expected? It might also make sense to keep the test that just use the print output to a separate file or also generate the IR checks for them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130177/new/

https://reviews.llvm.org/D130177