[PATCH] D133150: [llvm-exegesis] Cross compile all enabled targets

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 00:38:41 PDT 2022


courbet added a comment.

I'm not really qualified to comment on the `CMake` but this sounds conceptually fine apart from my comment on initialization.



================
Comment at: llvm/tools/llvm-exegesis/llvm-exegesis.cpp:301
 
-  InitializeNativeTarget();
-  InitializeNativeTargetAsmPrinter();
-  InitializeNativeTargetAsmParser();
+  InitializeAllTargets();
+  InitializeAllTargetMCs();
----------------
I think building all targets makes sens so that you can run an `llvm-exegesis` compiled on (say) X86  on AArch64. However at runtime we should only need to initialize the native target as we're going to jit compile and execute only for the host anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133150/new/

https://reviews.llvm.org/D133150



More information about the llvm-commits mailing list