[PATCH] D133107: [COFF] Don't generate -exclude-symbols for dllexported symbols

Thu Sep 1 22:45:48 PDT 2022

mstorsjo added a comment.

In D133107#3765989 <https://reviews.llvm.org/D133107#3765989>, @MaskRay wrote:

> Yes. I think this is better.
>
> Sent D133180 <https://reviews.llvm.org/D133180> to suppress hidden for dllexport as we do for dllimport.

Thanks. What do you think about this patch then - I think it still might be best to do this change? E.g. if other frontends than clang generate such IR - even if it is a bit tautological.

> `__attribute__((visibility("hidden"))) __declspec(dllexport)` should probably lead to an error.

Should, but doesn't yet - how hard do you think it'd be to add checking for that?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133107/new/

https://reviews.llvm.org/D133107