[PATCH] D132073: [CodeGen] Zero out only modified registers

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 15:00:28 PDT 2022


void added a comment.

In D132073#3765159 <https://reviews.llvm.org/D132073#3765159>, @efriedma wrote:

>> we shouldn't be zeroing %rdi
>
> I don't see how it's a problem if we zero rdi.  Even if we don't modify rdi, the caller doesn't have any way of knowing it wasn't modified.  The calling convention says it's caller-save.

This is just a test case. It's not meant to be definitive of the original bug. Just show the same symptoms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132073/new/

https://reviews.llvm.org/D132073



More information about the llvm-commits mailing list