[PATCH] D130177: [Matrix] Simplify matmuls with scalars

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 12:10:46 PDT 2022


thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:104
+template <typename LTy, typename RTy>
+inline auto m_AnyMul(const LTy &L, const RTy &R) {
+  return m_CombineOr(m_Mul(L, R), m_FMul(L, R));
----------------
fhahn wrote:
> nit: is `inline` the right thing here or should this be `static` instead?
Probably neither actually, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130177/new/

https://reviews.llvm.org/D130177



More information about the llvm-commits mailing list