[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D132513#3763209 <https://reviews.llvm.org/D132513#3763209>, @MaskRay wrote:

> Thanks for implementing this! The design looks good to me.
> I think it is powerful enough for my impending use case which is quite straightforward to reason about, without making the lit domain specific language too complex.

Great!  For others, that discussion is at https://discourse.llvm.org/t/lit-run-a-run-line-multiple-times-with-different-replacements/64932/15.

> Having the DEFINE/REDEFINE distinction looks good to me. If a substitution is defined in multiple places, knowing where they are redefined helps (like variable declarations and assignments.

Good analogy.  Perhaps I can work it into the documentation.

Thanks for the review.  I'll apply your suggestions on the next update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132513/new/

https://reviews.llvm.org/D132513