[PATCH] D133047: [DWARFLinker] Refactor clang modules loading code.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This looks reasonable to me.



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:415
 
+  struct RefModuleUnit {
+    RefModuleUnit(DWARFFile &File, std::unique_ptr<CompileUnit> Unit)
----------------
Doxygen comment?


================
Comment at: llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp:303
+  std::function<void(const DWARFUnit &Unit)> onCUDieLoaded =
+      [](const DWARFUnit &) {
+        // nothing to do yet.
----------------
should this be a default parameter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133047/new/

https://reviews.llvm.org/D133047