[PATCH] D133012: [AMDGPU] Add subtarget feature for MAD_U64/I64 bug on GFX11

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks reasonable to me.



================
Comment at: llvm/lib/Target/AMDGPU/VOP3Instructions.td:921
 defm V_DIV_SCALE_F64       : VOP3be_Real_gfx11<0x2fd, "V_DIV_SCALE_F64", "v_div_scale_f64">;
-defm V_MAD_U64_U32_gfx11   : VOP3be_Real_gfx11<0x2fe, "V_MAD_U64_U32_gfx11", "v_mad_u64_u32">;
-defm V_MAD_I64_I32_gfx11   : VOP3be_Real_gfx11<0x2ff, "V_MAD_I64_I32_gfx11", "v_mad_i64_i32">;
+let OtherPredicates = [HasMADIntraFwdBug] in {
+defm V_MAD_U64_U32_strict  : VOP3be_Real_gfx11<0x2fe, "V_MAD_U64_U32_strict", "v_mad_u64_u32">;
----------------
You shouldn't need to set OtherPredicates here. Real instructions usually copy these predicates from the Pseudo instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133012/new/

https://reviews.llvm.org/D133012