[PATCH] D133030: [AIX] llvm-readobj support a new option --exception-section for xcoff object file.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked an inline comment as done.
DiggerLin added a comment.

In D133030#3763317 <https://reviews.llvm.org/D133030#3763317>, @jhenderson wrote:

> 



> I did wonder whether this should really just be reusing the existing --unwind option, but as I understand it, the XCOFF exception section isn't really about unwinding the stack or anything along those lines. Is that correct?

yes, you are correct, the exception section is not for unwind. so we can not use the --unwind for it.

> Rather than canned binaries, I think it wouldn't be too hard to add yaml2obj support for exception sections, so that you can create the input at test time.

yes, if I do the yaml2obj first , I need a tools to decode the object file generated by yaml2obj when I add a test for the yaml2obj, but there is not now. My propose is three steps:

1. using canned binaries in this patch,
2. write a second patch to yaml2obj support for exception sections(using the llvm-readobj --exception-section to test the second patch).
3. have another patch to modify the llvm/test/tools/llvm-readobj/XCOFF/exception-section.test which use the yaml2obj to generate xcoff object with exception sections and replace the canned binaries in the test case.

> Your commit message should be a grammatically correct sentence, with leading capital letter (i.e. "Add a new ..."), much like comments.
>
> I've not really looked at the XCOFFObjectFile code changes or the testing just yet. Please don't forget to test error/warning paths, to show that the code can handle malformed inputs.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133030/new/

https://reviews.llvm.org/D133030