[PATCH] D132585: [VPlan] Add field to track if intrinsic should be used for call. (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8325
+                Range);
+  if (ShouldUseVectorIntrinsic) {
+    return new VPWidenCallRecipe(*CI, make_range(Ops.begin(), Ops.end()), ID);
----------------
Ayal wrote:
> nits: can drop `Should`, {}
Done in the committed version, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8333
+        // The following case may be scalarized depending on the VF.
+        // The flag shows whether we can use a usual Call for vectorized
+        // version of the instruction.
----------------
Ayal wrote:
> Maybe the following:
> ```
> // The flag shows whether it is better to scalarize the call than to call a vectorized version of the function.
> ```
> is a bit more accurate?
I updated the comment to
```
+  // Is better to call a vectorized version of the function than to to scalarize
+  // the call?
```

in the committed version/


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8340
+      Range);
+  if (ShouldUseVectorCall) {
+    return new VPWidenCallRecipe(*CI, make_range(Ops.begin(), Ops.end()),
----------------
Ayal wrote:
> nits: can drop `Should`, {}
Done in the committed version, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:949
 class VPWidenCallRecipe : public VPRecipeBase, public VPValue {
+  Intrinsic::ID VectorIntrinsicID;
 
----------------
Ayal wrote:
> nit: comment that not_intrinsic/false indicates that a library call is used instead of an intrinsic.
Added a comment in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132585/new/

https://reviews.llvm.org/D132585