[PATCH] D133095: [DwarfEhPrepare] Assign dummy debug location for inserted _Unwind_Resume calls (PR57469)

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 03:31:21 PDT 2022


jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM with one small maintainability nit.



================
Comment at: llvm/test/CodeGen/X86/dwarf-eh-prepare-dbg.ll:63
+
+; CHECK: [[DBG16]] = !DILocation(line: 0, scope: !12)
----------------
Having "!12" in the CHECK line is liable to future breakage if the metadata re-orders / upgrades / otherwise alters -- please instead capture the DISubprogram's node number and check against that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133095/new/

https://reviews.llvm.org/D133095



More information about the llvm-commits mailing list